Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't read auth in quill generate #181

Merged
merged 3 commits into from
Mar 23, 2023
Merged

fix: Don't read auth in quill generate #181

merged 3 commits into from
Mar 23, 2023

Conversation

adamspofford-dfinity
Copy link
Contributor

Stops quill from trying to read the provided pem file when running quill generate. Fixes #178.

@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner March 23, 2023 17:10
ericswanson-dfinity
ericswanson-dfinity requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note to the changelog, and a test.

@adamspofford-dfinity adamspofford-dfinity merged commit f1b99d4 into master Mar 23, 2023
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/patch-2 branch March 23, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cant generate key from seed
2 participants
@adamspofford-dfinity @ericswanson-dfinity